Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

136 add documentation for basic controller implementation #186

Merged

Conversation

samvanderzwan
Copy link
Contributor

Also fixed the building on read the docs so that autoclass is working and the docstring documentation is added on read the docs.

Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

doc/controller/controller.rst Outdated Show resolved Hide resolved
doc/controller/main_controller_class.rst Outdated Show resolved Hide resolved
doc/requirements.txt Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Contributor

@vanmeerkerk vanmeerkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve changes, with the comment that I find the change to the pyproject toml interesting/weird and I don't know whether it is necessary.

@vanmeerkerk
Copy link
Contributor

@samvanderzwan something is going wrong with the closing of this commit. Can you check?

@samvanderzwan samvanderzwan merged commit 20eabc7 into main Oct 24, 2024
6 checks passed
@samvanderzwan samvanderzwan deleted the 136-add-documentation-for-basic-controller-implementation branch October 24, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for basic Controller implementation
2 participants